ingest/ledgerbackend: Add core configuration support for BUCKETLIST_DB_MEMORY_FOR_CACHING#5632
Merged
tamirms merged 4 commits intostellar:masterfrom Mar 26, 2025
Merged
Conversation
tamirms
force-pushed
the
bucketlist-cache-flags
branch
from
fc761d3 to
a6cce78
Compare
Shaptic
approved these changes
Mar 25, 2025
Contributor
Shaptic
left a comment
Shaptic
left a comment
There was a problem hiding this comment.
I hate that we have to version parse, but this is as clean as it gets if we're gonna do that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
CHANGELOG.mdwithin the component folder structure. For example, if I changed horizon, then I updated (services/horizon/CHANGELOG.md. I add a new line item describing the change and reference to this PR. If I don't update a CHANGELOG, I acknowledge this PR's change may not be mentioned in future release notes.semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Fixes https://github.com/stellar/go/issues/5600
Disable
BUCKETLIST_DB_MEMORY_FOR_CACHINGby default in the captive core library. TheBUCKETLIST_DB_MEMORY_FOR_CACHINGconfiguration field was introduced in stellar-core version 22.2.0 so we can only apply the default when running a core binary with that version or higher. If we includeBUCKETLIST_DB_MEMORY_FOR_CACHINGin a core toml file for an older version of core, stellar-core will crash because it will not recognize the configuration field.Why
In an upcoming core release, the default value for
BUCKETLIST_DB_MEMORY_FOR_CACHINGwill be increased to potentially 3GB. If we omit theBUCKETLIST_DB_MEMORY_FOR_CACHINGfield in our captive core toml files then operators will see a sudden increase in memory usage by 3GB due to theBUCKETLIST_DB_MEMORY_FOR_CACHINGconfiguration. This extra memory is useful for validators but it is not a useful optimization for watcher nodes.Known limitations
[N/A]